Conversation
Most importantly, this allows closing the dialog with Escape. A (positive?) side effect is that in the dark theme when opening the dialog we will darken the background instead of lightening it. I have tested this on narrow screens and wide screens, comparing side-by-side with the original version. Everything should look almost the same, maybe except for the backdrop. This also fixes a small issue where the contents outside the dialog were keyboard-interactive.
The dialog is not that "important" so we should probably allow dismissing it more easily.
|
not sure about this one, in mobile the dialog goes full screen and there is no way to click outside |
|
Good point. Sorry, I should have mentioned that. On mobile it can be closed with the "navigate back" button. |
WofWca
force-pushed
the
wofwca/dialog-light-dismiss
branch
from
24e4f18 to
04255df
Compare
|
not sure if "navigate back" will work, it is not necessarily supported by the container app which might just close the webview, overall I think the button doesn't make things worse so better to leave for now 🤔 |
WofWca
force-pushed
the
wofwca/dialog-light-dismiss
branch
from
04255df to
2a5435f
Compare
|
In addition, https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/
I just think that the button takes too much space. We should consider replacing it with a smaller "cross" button at the top-right corner. |
3 participants
TODO: